[ 
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066330#comment-16066330
 ] 

ASF GitHub Bot commented on FLINK-7008:
---------------------------------------

Github user dianfu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4195#discussion_r124510810
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
 ---
    @@ -114,6 +115,28 @@ public DeweyNumber getVersion() {
                return version;
        }
     
    +   @Override
    +   public boolean equals(Object obj) {
    +           if (obj instanceof ComputationState) {
    +                   ComputationState other = (ComputationState) obj;
    +                   return Objects.equals(state, other.state) &&
    +                           event == other.event &&
    --- End diff --
    
    Make sense.


> Update NFA state only when the NFA changes.
> -------------------------------------------
>
>                 Key: FLINK-7008
>                 URL: https://issues.apache.org/jira/browse/FLINK-7008
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.3.1
>            Reporter: Kostas Kloudas
>            Assignee: Dian Fu
>             Fix For: 1.4.0
>
>
> Currently in the {{AbstractKeyedCEPPatternOperator.updateNFA()}} method we 
> update the NFA state every time the NFA is touched. This leads to redundant 
> puts/gets to the state when there are no changes to the NFA itself.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to