Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4187#discussion_r124235516
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
       </tbody>
     </table>
     
    +#### Connector:
    +<table class="table table-bordered">
    +  <thead>
    +    <tr>
    +      <th class="text-left" style="width: 20%">Scope</th>
    +      <th class="text-left" style="width: 30%">Metrics</th>
    +      <th class="text-left" style="width: 50%">Description</th>
    +    </tr>
    +  </thead>
    +  <tbody>
    +    <tr>
    +      <th rowspan="1">Slot/Consumer</th>
    +      <td>kafkaCommitsSucceeded</td>
    +      <td>Kafka offset commit success count if Kafka commit is turned 
on.</td>
    --- End diff --
    
    I would make this statement more strict, in that the metric only exists if 
commit is turned on AND checkpointing is enabled. The added metrics would not 
appear if only Kafka's periodic offset committing is turned on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to