Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4138#discussion_r123946049
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
 ---
    @@ -1560,6 +1561,13 @@ class CodeGenerator(
             requireArray(array)
             generateArrayElement(this, array)
     
    +      case ScalarSqlFunctions.CONCAT | ScalarSqlFunctions.CONCAT_WS =>
    +        this.config.setNullCheck(false)
    --- End diff --
    
    We cannot modify the config here. Maybe it makes sense not to use a 
`CallGenerator` but add the logic to `ScalarOperators`. Other arrays functions 
such as `generateArrayCardinality`, `generateArrayElement` are there as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to