Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4105#discussion_r122447088
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
 ---
    @@ -307,9 +315,29 @@ object UserDefinedFunctionUtils {
           aggregateFunction: AggregateFunction[_, _],
           extractedType: TypeInformation[_] = null)
         : TypeInformation[_] = {
    +    getGenericTypeOfAggregateFunction(aggregateFunction, "getResultType", 
0, extractedType)
    +  }
    +
    +  /**
    +    * Internal method of AggregateFunction#getAccumulatorType() that does 
some pre-checking
    +    * and uses [[TypeExtractor]] as default return type inference.
    +    */
    +  def getAccumulatorTypeOfAggregateFunction(
    +    aggregateFunction: AggregateFunction[_, _],
    +    extractedType: TypeInformation[_] = null)
    +  : TypeInformation[_] = {
    +    getGenericTypeOfAggregateFunction(aggregateFunction, 
"getAccumulatorType", 1, extractedType)
    +  }
    +
    +  private def getGenericTypeOfAggregateFunction(
    --- End diff --
    
    I would not call the method `getGenericTypeOfAggFunction` because this 
implies that it returns a `GenericType` which we want to avoid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to