[ 
https://issues.apache.org/jira/browse/FLINK-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031903#comment-16031903
 ] 

ASF GitHub Bot commented on FLINK-6781:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4036#discussion_r119464746
  
    --- Diff: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
 ---
    @@ -378,6 +388,11 @@ public JDBCInputFormatBuilder 
setRowTypeInfo(RowTypeInfo rowTypeInfo) {
                        return this;
                }
     
    +           public JDBCInputFormatBuilder setFetchSize(int fetchSize) {
    +                   format.fetchSize = fetchSize;
    --- End diff --
    
    let's add a `Preconditions` check that fetchSize is greater than 0.


> Make fetch size configurable in JDBCInputFormat
> -----------------------------------------------
>
>                 Key: FLINK-6781
>                 URL: https://issues.apache.org/jira/browse/FLINK-6781
>             Project: Flink
>          Issue Type: Improvement
>          Components: Batch Connectors and Input/Output Formats
>    Affects Versions: 1.2.1
>            Reporter: Maximilian Bode
>            Assignee: Maximilian Bode
>            Priority: Minor
>
> For batch jobs that read from large tables, it is useful to be able to 
> configure the SQL statement's fetch size. In particular, for Oracle's JDBC 
> driver the default fetch size is 10.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to