[
https://issues.apache.org/jira/browse/FLINK-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031272#comment-16031272
]
ASF GitHub Bot commented on FLINK-6785:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4035
[FLINK-6785] [metrics] Fix ineffective asserts in MetricRegistryTest
Asserts inside reporters are not inherently effective to detect test
failures, so I moved the asserts outside and access the required information
via static fields.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6785
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4035.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4035
----
commit 5e0d4a397e510f0b0d70e656819592ed52e855d2
Author: zentol <ches...@apache.org>
Date: 2017-05-31T14:49:43Z
[FLINK-6785] [metrics] Fix ineffective asserts in MetricRegistryTest
----
> Ineffective checks in MetricRegistryTest
> ----------------------------------------
>
> Key: FLINK-6785
> URL: https://issues.apache.org/jira/browse/FLINK-6785
> Project: Flink
> Issue Type: Bug
> Components: Metrics, Tests
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
>
> Several tests in {{MetricRegistryTest}} have reporters doing assertions. By
> design exceptions from reporters are however catched and logged, and thus
> can't fail the test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
