[
https://issues.apache.org/jira/browse/FLINK-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027312#comment-16027312
]
Chesnay Schepler commented on FLINK-6670:
-----------------------------------------
We may want to extend this issue to cover {{CommonTestUtils#getTempDir()}} and
{{ CommonTestUtils#createTmpFile()}} in {{flink-test-utils}}.
> remove CommonTestUtils.createTempDirectory()
> --------------------------------------------
>
> Key: FLINK-6670
> URL: https://issues.apache.org/jira/browse/FLINK-6670
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Reporter: Nico Kruber
> Assignee: Chesnay Schepler
> Priority: Minor
>
> {{CommonTestUtils.createTempDirectory()}} encourages a dangerous design
> pattern with potential concurrency issues in the unit tests as well as the
> need to cleanup the created directories.
> Instead, it should be solved by using the following pattern:
> {code:java}
> @Rule
> public TemporaryFolder tempFolder = new TemporaryFolder();
> {code}
> We should therefore remove {{CommonTestUtils.createTempDirectory()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
