[
https://issues.apache.org/jira/browse/FLINK-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027303#comment-16027303
]
ASF GitHub Bot commented on FLINK-6737:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4000
[FLINK-6737][table]Add over method supported string expression as inp…
In this PR only add over method supported string expression as input
parameter.
- [x] General
- The pull request references the related JIRA issue
("[FLINK-6737][table]Add over method supported string expression as input
parameter")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6737-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4000.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4000
----
commit 5acb389de1597e43855d0c6f2b7369ef7f3d80cf
Author: sunjincheng121 <sunjincheng...@gmail.com>
Date: 2017-05-27T06:03:06Z
[FLINK-6737][table]Add over method supported string expression as input
parameter
----
> Fix over expression parse String error.
> ---------------------------------------
>
> Key: FLINK-6737
> URL: https://issues.apache.org/jira/browse/FLINK-6737
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> When we run the TableAPI as follows:
> {code}
> val windowedTable = table
> .window(Over partitionBy 'c orderBy 'proctime preceding UNBOUNDED_ROW
> as 'w)
> .select('c, "countFun(b)" over 'w as 'mycount, weightAvgFun('a, 'b)
> over 'w as 'wAvg)
> {code}
> We get the error:
> {code}
> org.apache.flink.table.api.TableException: The over method can only using
> with aggregation expression.
> at
> org.apache.flink.table.api.scala.ImplicitExpressionOperations$class.over(expressionDsl.scala:469)
> at
> org.apache.flink.table.api.scala.ImplicitExpressionConversions$LiteralStringExpression.over(expressionDsl.scala:756)
> {code}
> The reason is, the `over` method of `expressionDsl` not parse the String case.
> I think we should fix this before 1.3 release.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
