[ 
https://issues.apache.org/jira/browse/FLINK-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025958#comment-16025958
 ] 

Chesnay Schepler commented on FLINK-6698:
-----------------------------------------

The only ones that are missing (and unassigned) are runtime, core, java and 
tests. I don't know about the state of gelly, but all that are assigned to me 
either have an open PR or are running on travis to find missed things/failing 
tests, except fink-contrib which is basically done but blocked by FLINK-6710.

The problem with the remaining modules is that there are just so many 
violations; we can't fix those at once. We'll need a discussion on how exactly 
we intend to introduce the rules to them. For now i would ignore flink-runtime 
completely as people are still very active in there; this luckily is not the 
case for the others.

There are a number of changes that we can already make without anyone 
complaining (i hope), which is removing tabs on empty lines, removing trailing 
spaces on empty javadoc lines, reordering imports, introducing an empty line 
before the package declaration and adding missing javadocs. These changes 
should be fine as they don't interfere with the git history for actual code 
that people are concerned about.

This will easily shave of a couple thousand violations, and then let's go from 
there.



> Activate strict checkstyle
> --------------------------
>
>                 Key: FLINK-6698
>                 URL: https://issues.apache.org/jira/browse/FLINK-6698
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Chesnay Schepler
>
> Umbrella issue for introducing the strict checkstyle, to keep track of which 
> modules are already covered.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to