[
https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025732#comment-16025732
]
ASF GitHub Bot commented on FLINK-6725:
---------------------------------------
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3993
[FLINK-6725][table] make requiresOver as a contracted method in udagg
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shaoxuan-wang/flink F6725-submit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3993.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3993
----
commit 5117a297c089de36723ac836b85502201c927dba
Author: shaoxuan-wang <wshaox...@gmail.com>
Date: 2017-05-26T02:52:31Z
[FLINK-6725][table] make requiresOver as a contracted method in udagg
----
> make requiresOver as a contracted method in udagg
> -------------------------------------------------
>
> Key: FLINK-6725
> URL: https://issues.apache.org/jira/browse/FLINK-6725
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> I realized requiresOver is defined in the udagg interface when I wrote up the
> udagg doc. I would like to put requiresOver as a contract method. This makes
> the entire udagg interface consistently and clean.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
