Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3976#discussion_r118244967
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java 
---
    @@ -1896,21 +1898,21 @@ public boolean filter(Event value) throws Exception 
{
                List<List<Event>> resultingPatterns = feedNFA(inputEvents, nfa);
     
                compareMaps(resultingPatterns, Lists.<List<Event>>newArrayList(
    -                           Lists.newArrayList(ConsecutiveData.startEvent, 
ConsecutiveData.middleEvent1, ConsecutiveData.middleEvent2, 
ConsecutiveData.end),
    -                           Lists.newArrayList(ConsecutiveData.startEvent, 
ConsecutiveData.middleEvent1, ConsecutiveData.middleEvent3, 
ConsecutiveData.end),
    -                           Lists.newArrayList(ConsecutiveData.startEvent, 
ConsecutiveData.end)
    +                           Lists.newArrayList(ConsecutiveData.START_EVENT, 
ConsecutiveData.MIDDLE_EVENT_1, ConsecutiveData.MIDDLE_EVENT_2, 
ConsecutiveData.END),
    +                           Lists.newArrayList(ConsecutiveData.START_EVENT, 
ConsecutiveData.MIDDLE_EVENT_1, ConsecutiveData.MIDDLE_EVENT_3, 
ConsecutiveData.END),
    +                           Lists.newArrayList(ConsecutiveData.START_EVENT, 
ConsecutiveData.END)
                ));
        }
     
        ///////////////////////////////         Consecutive           
////////////////////////////////////////
     
        private static class ConsecutiveData {
    -           static final Event startEvent = new Event(40, "c", 1.0);
    -           static final Event middleEvent1 = new Event(41, "a", 2.0);
    -           static final Event middleEvent2 = new Event(42, "a", 3.0);
    -           static final Event middleEvent3 = new Event(43, "a", 4.0);
    -           static final Event middleEvent4 = new Event(43, "a", 5.0);
    -           static final Event end = new Event(44, "b", 5.0);
    +           static final Event START_EVENT = new Event(40, "c", 1.0);
    --- End diff --
    
    Did not know that. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to