Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/681#issuecomment-105982832
Looks very nice now. Few comments:
- I suggest to keep the JobID in the JobGraph final and force it to be
passed via the constructor. The JobGraphGenerator would need to accept the
JobID as a parameter then.
- Let's keep the actor system in the `Client` alive. The startup of the
actor system is the longest delay in all client commands. For proper
interactive behavior, we need to keep it running. Start it on first use, and
stop it when the client is shut down. We need to make sure the client is always
shut down, in the remote executor, and in the CLI frontend.
- We can probably remove the "lastJobID" from the client, it seems
redundant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
