Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3885#discussion_r116488176
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
 ---
    @@ -318,9 +318,10 @@ public void addVirtualSideOutputNode(Integer 
originalId, Integer virtualId, Outp
                                continue;
                        }
     
    -                   if 
(!tag.f1.getTypeInfo().equals(outputTag.getTypeInfo())) {
    -                           throw new IllegalArgumentException("Trying to 
add a side input for the same id " +
    -                                           "with a different type. This is 
not allowed.");
    +                   if (tag.f1.getId().equals(outputTag.getId()) &&
    +                                   
!tag.f1.getTypeInfo().equals(outputTag.getTypeInfo())) {
    +                           throw new IllegalArgumentException("Trying to 
add a side output for the same" +
    +                                           "side-output id with a 
different type. This is not allowed.");
    --- End diff --
    
    Could also include the tag name for good measure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to