[
https://issues.apache.org/jira/browse/FLINK-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010280#comment-16010280
]
ASF GitHub Bot commented on FLINK-6439:
---------------------------------------
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/3904
[FLINK-6439] Fix close OutputStream && InputStream in OperatorSnapshotUtil
…tUtil
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-6439
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3904
----
commit 85fc9997d18bd6693b468a4cca9e495da6303d63
Author: zjureel <zjur...@gmail.com>
Date: 2017-05-15T10:14:11Z
[FLINK-6439] Fix close OutputStream && InputStream in OperatorSnapshotUtil
----
> Unclosed InputStream in OperatorSnapshotUtil#readStateHandle()
> --------------------------------------------------------------
>
> Key: FLINK-6439
> URL: https://issues.apache.org/jira/browse/FLINK-6439
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Ted Yu
> Assignee: Fang Yong
> Priority: Minor
>
> {code}
> FileInputStream in = new FileInputStream(path);
> DataInputStream dis = new DataInputStream(in);
> {code}
> None of the in / dis is closed upon return from the method.
> In writeStateHandle(), OutputStream should be closed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
