[ 
https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010270#comment-16010270
 ] 

ASF GitHub Bot commented on FLINK-6288:
---------------------------------------

Github user zjureel commented on the issue:

    https://github.com/apache/flink/pull/3901
  
    @tzulitai I created the new PR here for issue 6288. As discussed in 
[https://github.com/apache/flink/pull/3766](url), there are two ways to control 
timeout of fetching kafka meta
    
    1. Depend on the timeout mechanism of kafka. When fetching partition meta 
from kafka, some timeout configurations should be setted.
    2. Using `Future` to get the partiton meta of kafka, and user can set the 
timeout with configuration.
    
    In the new api, meta of kafka may be feched before data is sended, and some 
exceptions such as network or disk problem may still block data send even that 
user set the request timeout of kafka. So in the PR, I use Future to control 
the timeout of fetching kafka meta.
    
    The problem may not be so complicated, and we can use the timeout mechanism 
of kafka directly. What do you think of it? Thanks.
    



> FlinkKafkaProducer's custom Partitioner is always invoked with number of 
> partitions of default topic
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6288
>                 URL: https://issues.apache.org/jira/browse/FLINK-6288
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Fang Yong
>
> The {{FlinkKafkaProducerBase}} supports routing records to topics besides the 
> default topic, but the custom {{Partitioner}} interface does not follow this 
> semantic.
> The partitioner is always invoked the {{partition}} method with the number of 
> partitions in the default topic, and not the number of partitions of the 
> current {{targetTopic}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to