Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3881#discussion_r116185935
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -346,11 +346,7 @@ public int exists(String pathInZooKeeper) throws
Exception {
} else {
// Initial cVersion (number of changes to the
children of this node)
int initialCVersion = stat.getCversion();
-
- List<String> children =
ZKPaths.getSortedChildren(
-
client.getZookeeperClient().getZooKeeper(),
-
ZKPaths.fixForNamespace(client.getNamespace(), "/"));
-
+ List<String> children =
client.getZookeeperClient().getZooKeeper().getChildren(ZKPaths.fixForNamespace(client.getNamespace(),
"/"), false);
--- End diff --
I think this alone does not work: The JavaDocs of `ZooKeeper#getChildren`
say
> The list of children returned is not sorted and no guarantee is provided
as to its natural or lexical order.
Thus, I assume that it is not safe to simply return the list of children
without any further processing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
