[ 
https://issues.apache.org/jira/browse/FLINK-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559277#comment-14559277
 ] 

ASF GitHub Bot commented on FLINK-2096:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/726

    [FLINK-2096] Remove implicit conversion from Window Stream to Stream

    This causes unexpected behaviour, for example in:
    
    ds.window(...).map(..)
    
    The user would expect some kind of windowing to take place. The
    windowing, however, cancels out with the implicitly inserted flatten()
    call.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink stream-remove-implicit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #726
    
----
commit 93958593b96a2137b86de149c7a757ba4e08c428
Author: Aljoscha Krettek <aljoscha.kret...@gmail.com>
Date:   2015-05-26T15:44:21Z

    [FLINK-2096] Remove implicit conversion from Window Stream to Stream
    
    This causes unexpected behaviour, for example in:
    
    ds.window(...).map(..)
    
    The user would expect some kind of windowing to take place. The
    windowing, however, cancels out with the implicitly inserted flatten()
    call.

----


> Remove implicit conversions in Streaming Scala API
> --------------------------------------------------
>
>                 Key: FLINK-2096
>                 URL: https://issues.apache.org/jira/browse/FLINK-2096
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Aljoscha Krettek
>
> At least one user ran into a problem with this: 
> http://stackoverflow.com/questions/30461809/in-flink-stream-windowing-does-not-seem-to-work
> Also, the implicit conversions from Java DataStreams to Scala Streams could 
> be problematic. I think we should at least make them private to the flink 
> package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to