[
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004951#comment-16004951
]
ASF GitHub Bot commented on FLINK-5256:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3673#discussion_r115786774
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,11 +366,219 @@ class JoinITCase(
val sqlQuery1 = "SELECT * FROM A CROSS JOIN (SELECT count(*) FROM A
HAVING count(*) < 0)"
val result = tEnv.sql(sqlQuery1).count()
-
Assert.assertEquals(0, result)
}
@Test
+ def testLeftNullLeftJoin (): Unit = {
--- End diff --
Several of these tests are executed with regular joins because of the
restriction that for an outer single row join, the single row input must be on
the inner side. Some of these tests have the single row input on the outer side
which will translate them into regular joins (which is only possible because
the join conditions are equality predicates). These tests can be removed,
because they test the existing join implementation.
In order to enforce tests of the new outer single row joins, the join
condition must be an inequality predicate. It would be good to adapt the tests
queries accordingly.
> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
> Key: FLINK-5256
> URL: https://issues.apache.org/jira/browse/FLINK-5256
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Dmytro Shkvyra
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and
> right joins with single input. These cases can be handled if the
> {{DataSetSingleRowJoin}} is extended to support outer joins on the
> non-single-row input, i.e., left joins if the right side is single input and
> vice versa.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
