Github user DmytroShkvyra commented on a diff in the pull request:
https://github.com/apache/flink/pull/3673#discussion_r115742779
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/DataSetSingleRowJoinTest.scala
---
@@ -187,9 +187,155 @@ class SingleRowJoinTest extends TableTestBase {
),
term("where", "AND(<(a1, b1)", "=(a2, b2))"),
term("join", "a1", "a2", "b1", "b2"),
- term("joinType", "NestedLoopJoin")
+ term("joinType", "NestedLoopInnerJoin")
)
util.verifySql(query, expected)
}
+
+ @Test
+ def testSingleRowJoinLeftOuterJoin(): Unit = {
+ val util = batchTestUtil()
+ util.addTable[(Long, Int)]("A", 'a1, 'a2)
+ util.addTable[(Int, Int)]("B", 'b1, 'b2)
+
+ val queryLeftJoin =
+ "SELECT a2 FROM A " +
+ "LEFT JOIN " +
+ "(SELECT COUNT(*) AS cnt FROM B) " +
+ "AS x " +
+ "ON a1 = cnt"
+
+ val expected =
+ unaryNode(
+ "DataSetCalc",
+ unaryNode(
+ "DataSetSingleRowJoin",
+ batchTableNode(0),
+ term("where", "=(a1, cnt)"),
+ term("join", "a1", "a2", "cnt"),
+ term("joinType", "NestedLoopLeftJoin")
+ ),
+ term("select", "a2")
+ ) + "\n" +
+ unaryNode(
+ "DataSetAggregate",
+ unaryNode(
+ "DataSetUnion",
+ unaryNode(
+ "DataSetValues",
+ unaryNode(
+ "DataSetCalc",
+ batchTableNode(1),
+ term("select", "0 AS $f0")),
+ tuples(List(null)), term("values", "$f0")
+ ),
+ term("union", "$f0")
+ ),
+ term("select", "COUNT(*) AS cnt")
+ )
+
+ util.verifySql(queryLeftJoin, expected)
+ }
+
+ @Test
+ def testSingleRowJoinRightOuterJoin(): Unit = {
+ val util = batchTestUtil()
+ util.addTable[(Long, Int)]("A", 'a1, 'a2)
+ util.addTable[(Int, Int)]("B", 'b1, 'b2)
+
+ val queryRightJoin =
--- End diff --
@fhueske see `term("joinType", "RightOuterJoin")` in plan.
I was really confused about "Disable outer joins with non-equality
predicates" in https://issues.apache.org/jira/browse/FLINK-5520. Everything
works fine until this update.
Do you want extend scope of this PR for support non-equality predicates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
