[
https://issues.apache.org/jira/browse/FLINK-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999839#comment-15999839
]
ASF GitHub Bot commented on FLINK-6471:
---------------------------------------
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/3837
[FLINK-6471] [checkpoint] Fix RocksDBStateBackendTest
`RocksDBStateBackendTest::testCancelRunningSnapshot` sometimes failes. This
is cause by a problem that I fixed in `BlockerCheckpointStreamFactory`.
However, it seems like for unknown reason (probably a move refactoring +
merge) this class existed twice, with all duplicated code. This PR deletes the
copy and uses the one correct implementation everywhere.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink FLINK-6471
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3837
----
----
> RocksDBStateBackendTest#testCancelRunningSnapshot sometimes fails
> -----------------------------------------------------------------
>
> Key: FLINK-6471
> URL: https://issues.apache.org/jira/browse/FLINK-6471
> Project: Flink
> Issue Type: Test
> Reporter: Ted Yu
> Priority: Minor
>
> I got the following test failure based on commit
> f37988c19adc30d324cde83c54f2fa5d36efb9e7 :
> {code}
> testCancelRunningSnapshot[1](org.apache.flink.contrib.streaming.state.RocksDBStateBackendTest)
> Time elapsed: 0.166 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.flink.contrib.streaming.state.RocksDBStateBackendTest.testCancelRunningSnapshot(RocksDBStateBackendTest.java:313)
> Results :
> Failed tests:
> RocksDBStateBackendTest.testCancelRunningSnapshot:313 null
> {code}
> The following assertion fails:
> {code}
> assertTrue(testStreamFactory.getLastCreatedStream().isClosed());
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
