[
https://issues.apache.org/jira/browse/FLINK-5978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998137#comment-15998137
]
ASF GitHub Bot commented on FLINK-5978:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3831
[FLINK-5978][FLINK-6459][FLINK-6461] Move web-related config parameters to
JMOptions
This PR contains the remaining steps to moving all web-related
configuration parameters to the `JobManagerOptions` class.
* contains a rebased and cleaned up version of #3552
* moves the `ACCESS_CONTROL_ORIGIN` ConfigOption
* deprecates the remaining web-related default values in ConfigConstants,
and replaces all usages of them
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink web_config_stuff
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3831
----
commit a353214a2b770262e8ac2537fd7b23a81f0a5aca
Author: mengji.fy <mengji...@taobao.com>
Date: 2017-05-05T10:11:20Z
[FLINK-5978] Move JM WebFrontend address ConfigOption to JMOptions
This closes #3552.
commit 34598d58185e6bfeb33709e890511226c10f2fa5
Author: zentol <ches...@apache.org>
Date: 2017-05-05T10:13:10Z
[FLINK-6459] Move origin header ConfigOption to JMOptions
commit d674fa7ce4007adbe36760c4cc175949efa145eb
Author: zentol <ches...@apache.org>
Date: 2017-05-05T10:39:55Z
[FLINK-6461] Deprecate web config defaults in ConfigConstants
----
> JM WebFrontend address ConfigOption is defined in ConfigConstants
> -----------------------------------------------------------------
>
> Key: FLINK-5978
> URL: https://issues.apache.org/jira/browse/FLINK-5978
> Project: Flink
> Issue Type: Bug
> Components: JobManager
> Affects Versions: 1.3.0
> Reporter: Chesnay Schepler
> Assignee: Fang Yong
> Priority: Blocker
> Fix For: 1.3.0
>
>
> The DEFAULT_JOB_MANAGER_WEB_FRONTEND_ADDRESS ConfigOption is defined in
> ConfigConstants instead of JobManagerOptions.
> Additionally, the name should not contain DEFAULT_ since it doesn't even
> define a default value...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
