[
https://issues.apache.org/jira/browse/FLINK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997745#comment-15997745
]
ASF GitHub Bot commented on FLINK-5884:
---------------------------------------
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3808#discussion_r114925594
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
---
@@ -150,3 +133,30 @@ case class WindowReference(name: String) extends
Attribute {
}
}
}
+
+abstract class TimeAttribute(val expression: Expression)
+ extends UnaryExpression
+ with NamedExpression {
+
+ override private[flink] def child: Expression = expression
+
+ override private[flink] def name: String = expression match {
+ case UnresolvedFieldReference(name) => name
+ case _ => throw new ValidationException("Unresolved field reference
expected.")
+ }
+
+ override private[flink] def toAttribute: Attribute =
+ throw new UnsupportedOperationException("Time attribute can not be
used solely.")
+}
+
+case class RowtimeAttribute(expr: Expression) extends TimeAttribute(expr) {
--- End diff --
1. Not allow `TimeAttribute` make sense for me. +1
2. Forbidden `proctime` on existing field that's I want to see.+1
3. About ` rowtime `on existing attribute,I'am not sure. But I think in a
Stream environment, If we want query the `rowtime` column, It should be a
physical field. And if only a indicators of time mode. I think It should not be
a physical field. Because there is no place to apply this value. I had left a
question to @twalthr in first review summary. So I want to know @twalthr 's
opinion? :)
> Integrate time indicators for Table API & SQL
> ---------------------------------------------
>
> Key: FLINK-5884
> URL: https://issues.apache.org/jira/browse/FLINK-5884
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Blocker
> Fix For: 1.3.0
>
>
> We already discussed the need for a proper integration of time indicators
> (event-time or processing-time) for both the Table API & SQL on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Table-API-SQL-indicators-for-event-and-processing-time-tp15927.html
> This issue will track the progress. I will work on a design document how we
> can solve this issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
