Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/720#discussion_r30986863
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -150,6 +150,12 @@ public void testMerged() {
validate(parameter);
}
+ @Test
+ public void testFromGenericOptionsParser() throws IOException {
+ ParameterTool parameter =
ParameterTool.fromGenericOptionsParser(new String[]{"-D", "input=myInput",
"-DexpectedCount=15"});
+ validate(parameter);
+ }
--- End diff --
Sorry that I didn't write this earlier when I did the first review of the
pull request:
Can you also add a test where we read one of the arguments (say
input=myinput) from a xml configuration file.
As far as I can see, the GenericOptionsParser also supports specifying
`-conf path/to/file.xml`.
That would be amazing ,)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
