[ 
https://issues.apache.org/jira/browse/FLINK-5720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996620#comment-15996620
 ] 

ASF GitHub Bot commented on FLINK-5720:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3816#discussion_r114756625
  
    --- Diff: 
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/KeyedStream.scala
 ---
    @@ -183,7 +183,10 @@ class KeyedStream[T, K](javaStream: KeyedJavaStream[T, 
K]) extends DataStream[T]
        * Creates a new [[DataStream]] by folding the elements of this 
DataStream
        * using an associative fold function and an initial value. An 
independent 
        * aggregate is kept per key.
    +   *
    +   * @deprecated will be removed in a future version
        */
    +  @Deprecated
    --- End diff --
    
    I don't know, actually. It seems actual (random) code on GitHub only has it 
in the annotation: 
https://github.com/ReactiveX/RxScala/blob/0.x/src/main/scala/rx/lang/scala/Observable.scala#L4876


> Deprecate "Folding" in all of DataStream API
> --------------------------------------------
>
>                 Key: FLINK-5720
>                 URL: https://issues.apache.org/jira/browse/FLINK-5720
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Aljoscha Krettek
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> Folding is an operation that cannot be done incrementally in a distributed 
> way and that also cannot be done on merging windows. Now that we have 
> {{AggregatingState}} and aggregate operations we should deprecate folding in 
> the APIs and deprecate {{FoldingState}}.
> I suggest to remove folding completely in Flink 2.0



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to