Github user shixiaogang commented on the issue:

    https://github.com/apache/flink/pull/3801
  
    @StefanRRichter  Thanks a lot for your review. I have updated the pull 
request as suggested. The following changes are made
    
    1. Remove the checkpoint type for incremental checkpoints. Now the support 
for incremental checkpointing becomes a configurable feature in 
`RocksDBKeyedStateBackend`, just like asynchronous checkpointing in 
`HeapKeyedStateBackend`. Incremental checkpointing will be performed if the 
feature is enabled and the checkpoint to perform is not a savepoint.
    
    2. Rename `RocksDBKeyedStateHandle` to `RocksDBIncrementalKeyedStateHandle` 
and do some refactoring.
    
    3. Allow `KeyedStateHandle` to register shared states.
    
    4. Maintain the information of last completed checkpoint with the 
notification of `AbstractStreamOperator`.
    
    5. Parameterize `RocksDBStateBackendTest` to test the cleanup of resources 
in both full and incremental checkpointing.
    
    6. Parameterize `PartitionedStateCheckpointingITCase` to test the 
snapshotting and restoring with different backend settings.
    
    It's appreciated if you can take a look at these changes. Any comment is 
welcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to