[
https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988666#comment-15988666
]
ASF GitHub Bot commented on FLINK-6337:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3785#discussion_r113905412
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java
---
@@ -68,7 +68,6 @@ public void testSuccessfulProgramAfterFailure() {
try {
runKMeans(cluster.getLeaderRPCPort());
- fail("This program execution should have
failed.");
--- End diff --
I think that the idea of the test is to check that another program can be
executed after one failed. The commit message introducing the test says "This
test validates that task slots in co-location constraints are properly freed in
the presence of failures." By removing this line, we are not testing what we
actually wanted to test anymore. We should keep the line but instead decrease
the number of configured buffers, for example 640 works instead of 840. That
way we keep the behaviour: successful job, failed job, successful job.
> Remove the buffer provider from PartitionRequestServerHandler
> -------------------------------------------------------------
>
> Key: FLINK-6337
> URL: https://issues.apache.org/jira/browse/FLINK-6337
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
>
> Currently, {{PartitionRequestServerHandler}} will create a
> {{LocalBufferPool}} when the channel is registered. The {{LocalBufferPool}}
> is only used to get segment size for creating read view in
> {{SpillableSubpartition}}, and the buffers in the pool will not be used all
> the time, so it will waste the buffer resource of global pool.
> We would like to remove the {{LocalBufferPool}} from the
> {{PartitionRequestServerHandler}}, and the {{LocalBufferPool}} in
> {{ResultPartition}} can also provide the segment size for creating sub
> partition view.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
