Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3673#discussion_r113663948
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/generated.scala
 ---
    @@ -35,7 +35,11 @@ case class GeneratedExpression(
         resultTerm: String,
         nullTerm: String,
         code: String,
    -    resultType: TypeInformation[_])
    +    resultType: TypeInformation[_]) {
    +
    +  var leftNullTerm: String = _
    --- End diff --
    
    I don't think we need these attributes.
    We can check with `${codeGenerator.input1Term} == null` whether an input 
record is null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to