Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3748#discussion_r112615718
  
    --- Diff: 
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
 ---
    @@ -402,6 +410,20 @@ public void testCassandraTupleAtLeastOnceSink() throws 
Exception {
        }
     
        @Test
    +   public void testCassandraRowAtLeastOnceSink() throws Exception {
    +           StreamExecutionEnvironment env = 
StreamExecutionEnvironment.getExecutionEnvironment();
    +           env.setParallelism(1);
    +
    +           DataStreamSource<org.apache.flink.types.Row> source = 
env.fromCollection(rowCollection);
    +           source.addSink(new CassandraRowSink(INSERT_DATA_QUERY, 
builder));
    --- End diff --
    
    This should use the CassandraRowSinkBuilder to test the row type detection. 
I know other tests don't do that either, but the should actually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to