Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/692#discussion_r30785537
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/Regularization.scala
---
@@ -95,6 +95,7 @@ abstract class DiffRegularization extends Regularization {
regParameter: Double)
}
+// TODO(tvas): I think NoRegularization should extend DiffRegularization
--- End diff --
Because the idea is to disallow setting non-differentiable regularization
in solver like L-BFGS which require differentiable loss, through type-matching.
By setting NoRegularization to extend DiffRegularization we would be able
to use it with L-BFGS
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
