[
https://issues.apache.org/jira/browse/FLINK-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537281#comment-14537281
]
ASF GitHub Bot commented on FLINK-1964:
---------------------------------------
GitHub user carloscurotto opened a pull request:
https://github.com/apache/flink/pull/666
[FLINK-1964] Rework TwitterSource to use a Properties object
I have changed TwitterSource and its related code to use a properties
object insted of a file path so we could inject properties from different
sources.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/carloscurotto/flink
twitter-source-properties-object
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/666.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #666
----
commit a1074145a0fdb24faa1bd29cc82c7c33666b4151
Author: Carlos Curotto <carloscuro...@gmail.com>
Date: 2015-05-07T03:07:32Z
[FLINK-1964] Rework TwitterSource to use a Properties object instead of a
file path
----
> Rework TwitterSource to use a Properties object instead of a file path
> ----------------------------------------------------------------------
>
> Key: FLINK-1964
> URL: https://issues.apache.org/jira/browse/FLINK-1964
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 0.9
> Reporter: Robert Metzger
> Assignee: Carlos Curotto
> Priority: Minor
> Labels: starter
>
> The twitter connector is very hard to use on a cluster because it expects the
> property file to be present on all nodes.
> It would be much easier to ask the user to pass a Properties object
> immediately.
> Also, the javadoc of the class stops in the middle of the sentence.
> It was not obvious to me how the two examples TwitterStreaming and
> TwitterTopology differ. Also, there is a third TwitterStream example in the
> streaming examples.
> The documentation of the Twitter source refers to the non existent
> TwitterLocal class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
