Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/659#discussion_r29854243
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/operators/windowing/GroupedActiveDiscretizer.java
---
@@ -60,29 +62,45 @@ public void run() throws Exception {
groupedDiscretizers.put(key,
groupDiscretizer);
}
- groupDiscretizer.processRealElement(nextObject);
+ groupDiscretizer.processRealElement(element);
}
- }
- for (StreamDiscretizer<IN> group :
groupedDiscretizers.values()) {
- group.emitWindow();
- }
+
}
@Override
public void open(org.apache.flink.configuration.Configuration
parameters) throws Exception {
super.open(parameters);
- centralThread = new Thread(new CentralCheck());
+ centralCheck = new CentralCheck();
+ centralThread = new Thread(centralCheck);
centralThread.start();
}
+ @Override
+ public void close() throws Exception {
+ super.close();
+ for (StreamDiscretizer<IN> group :
groupedDiscretizers.values()) {
+ group.emitWindow();
+ }
+
+ try {
+ centralCheck.running = false;
+ centralThread.interrupt();
+ centralThread.join();
+ } catch (InterruptedException e) {
+ e.printStackTrace();
--- End diff --
ouch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
