Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/553#discussion_r29662751
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
    @@ -1894,6 +1895,52 @@ object TaskManager {
           override def getValue: Double =
             ManagementFactory.getOperatingSystemMXBean().getSystemLoadAverage()
         })
    +    
    +    // Preprocessing steps for registering cpuLoad
    +    // fetch the method to get process CPU load
    +    val getCPULoadMethod: Method = getMethodToFetchCPULoad()
    --- End diff --
    
    Why not making `getCPULoadMethod` an `Option[Method]`? That way one avoids 
vicious `null` values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to