Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29572548
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +130,41 @@ class TaskManager(val connectionInfo:
InstanceConnectionInfo,
override def getValue: Double =
ManagementFactory.getOperatingSystemMXBean().getSystemLoadAverage()
})
+
+ // Preprocessing steps for registering cpuLoad
+ // fetch the method to get process CPU load
+ val getCPULoadMethod: Method = getMethodToFetchCPULoad()
+
+ // define the fetchCPULoad method as per the fetched getCPULoadMethod
+ val fetchCPULoad: (Any) => Double = if (getCPULoadMethod != null) {
+ (obj: Any) => getCPULoadMethod.invoke(obj).asInstanceOf[Double]
+ } else {
+ (obj: Any) => {
+ log.warning("getProcessCpuLoad method not available in the Operating
System Bean" +
+ "implementation for this Java runtime
environment",Thread.currentThread().getStackTrace)
+ -1
+ }
+ }
+
+ metricRegistry.register("cpuLoad", new Gauge[Double] {
+ override def getValue: Double = {
+ try{
+ val osMXBean = ManagementFactory.getOperatingSystemMXBean().
+ asInstanceOf[com.sun.management.OperatingSystemMXBean]
+ return fetchCPULoad(osMXBean)
+ } catch {
+ case t:Throwable => {
+ if (t.isInstanceOf[java.lang.ClassCastException]){
--- End diff --
I'm not a Scala expert, but I think you can avoid the t.isInstanceOf by
matching the exception with the pattern matching (case ..)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
