Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/581#issuecomment-94911176
This looks much better. Being not densely integrated into the DataStream
makes it easier to maintain.
The `InetAddress.getLocalHost().getHostAddress()` problem still persist in
my opinion. This command gives some host name, usually the one tied to the
local device.
Many machines (especially cloud servers) have various addresses and various
hostnames, not all of them exposed. Take an EC2 instance, which has at least
three network interfaces
- loopback: hostname is "localhost" or whatever you configure as the
hostname (it is "herman" in my case). Not necessarily registered at the DNS.
- A cloud internal one "10.x.x.x", hostname is something like
"ec2-europ1-z3-81-internal.amazonaws.com"
- An external one, such as "203.0.113.25", hostname is something like
"ec2-203-0-113-25.compute-1.amazonaws.com"
If your command returns "herman", this is probably not of much help, when
what you want is actually "ec2-europ1-z3-81-internal.amazonaws.com"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
