[ 
https://issues.apache.org/jira/browse/FLINK-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499854#comment-14499854
 ] 

ASF GitHub Bot commented on FLINK-1758:
---------------------------------------

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/576#discussion_r28595115
  
    --- Diff: 
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/EdgeDirection.java
 ---
    @@ -20,10 +20,10 @@
     
     /**
      * The EdgeDirection is used to select a node's neighborhood
    - * by the {@link Graph#reduceOnEdges(EdgesFunction, EdgeDirection)},
    - * {@link Graph#reduceOnEdges(EdgesFunctionWithVertexValue, 
EdgeDirection)},
    - * {@link Graph#reduceOnNeighbors(NeighborsFunction, EdgeDirection)} and
    - * {@link Graph#reduceOnNeighbors(NeighborsFunctionWithVertexValue, 
EdgeDirection)}
    + * by the {@link Graph#groupReduceOnEdges(EdgesFunction, EdgeDirection)},
    --- End diff --
    
    isn't it used in both cases?


> Extend Gelly's neighborhood methods
> -----------------------------------
>
>                 Key: FLINK-1758
>                 URL: https://issues.apache.org/jira/browse/FLINK-1758
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Vasia Kalavri
>            Assignee: Andra Lungu
>
> Currently, the neighborhood methods only allow returning a single value per 
> vertex. In many cases, it is desirable to return several or no value per 
> vertex. This is the case in clustering coefficient computation, 
> vertex-centric jaccard, algorithms where a vertex computes a value per edge 
> or when a vertex computes a value only for some of its neighbors.
> This issue proposes to 
> - change the current reduceOnEdges/reduceOnNeighbors methods to use 
> combinable reduce operations where possible
> - provide groupReduce-versions, which will use a Collector and allow 
> returning none or more values per vertex.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to