Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-90233701
Hey @andralungu! Thanks a lot for your work on this :)
I only took a quick look at your changes for now, but it seems that all
issues are fixed.
This PR introduces a lot of changes, so I would like to look into it more
carefully. Also, it'd be great if one more person could review.
Next, I think we should add a few tests to make sure we don't break
existing functionality and that the newly introduced options work as expected.
More specifically, I would test the following:
- if no direction is given, the iteration works as before, i.e. collecting
messages from in-neighbors and sending messages to out-neighbors .
- if direction is set to IN / OUT / ALL
- if the degrees option is not set, the vertex cannot access the degree,
i.e. no method is available or an error is produced
- if the degrees option is set, the degrees can be accessed in all
supersteps and their values are correct
- combination of the above, e.g. set direction to ALL and degrees.
I guess adding those tests will be easier after we merge #547 and make the
new options part of the configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
