[ 
https://issues.apache.org/jira/browse/FLINK-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394886#comment-14394886
 ] 

Felix Neutatz commented on FLINK-1820:
--------------------------------------

I think we should handle all types equally. Either we interpret empty strings 
as 0 like in the case of Long and Integer or we throw an exception like in the 
case of Double and Float. 

The third option would be to assign null to these values.

Moreover I am currently working with the TPC-DS benchmark. In my opinion the 
CSVReader should be able to read the corresponding input files.

> Bug in DoubleParser and FloatParser - empty String is not casted to 0
> ---------------------------------------------------------------------
>
>                 Key: FLINK-1820
>                 URL: https://issues.apache.org/jira/browse/FLINK-1820
>             Project: Flink
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.0, 0.9, 0.8.1
>            Reporter: Felix Neutatz
>            Assignee: Felix Neutatz
>            Priority: Critical
>             Fix For: 0.9
>
>
> Hi,
> I found the bug, when I wanted to read a csv file, which had a line like:
> "||\n"
> If I treat it as a Tuple2<Long,Long>, I get as expected a tuple (0L,0L).
> But if I want to read it into a Double-Tuple or a Float-Tuple, I get the 
> following error:
> java.lang.AssertionError: Test failed due to a 
> org.apache.flink.api.common.io.ParseException: Line could not be parsed: '||'
> ParserError NUMERIC_VALUE_FORMAT_ERROR 
> This error can be solved by adding an additional condition for empty strings 
> in the FloatParser / DoubleParser.
> We definitely need the CSVReader to be able to read "empty values".
> I can fix it like described if there are no better ideas :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to