Github user matadorhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/546#discussion_r27441775
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerAsync.java
---
@@ -43,7 +45,10 @@
/** Flag to signify that the IOManager has been shut down already */
private final AtomicBoolean isShutdown = new AtomicBoolean();
-
+
+ /** Logging */
+ protected static final Logger LOG =
LoggerFactory.getLogger(IOManagerAsync.class);
--- End diff --
@hsaputra Yes, private here is better. Thanks you. I have updated it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
