Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/408#issuecomment-77750264
  
    I am just dropping some more thoughts here ;-)
    
    The interface seems a bit confusing. Right now, one has to first create the 
iteration from the graph and then tell the graph to run it:
    ``` java
    GatherSumApplyIteration iteration = 
graph.createGatherSumApplyIteration(gather, sum, apply);
    Graph result = graph.runGatherSumApplyIteration(iteration);
    ```
    
    What was the reason to not go simply for 
    ``` java 
    Graph result = graph.runGatherSumApplyIteration(gather, sum, apply);
    ```
    
    If the reason was additional parameterization of the iteration, would it be 
nicer do go for the following?
    ``` java
    GatherSumApplyIteration iteration = 
graph.createGatherSumApplyIteration(gather, sum, apply);
    iteration.configureInSomeWay(...);
    Graph result = iteration.result();
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to