[
https://issues.apache.org/jira/browse/FLEX-35090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283154#comment-15283154
]
Hays Clark edited comment on FLEX-35090 at 5/13/16 9:04 PM:
------------------------------------------------------------
This work has already been done and is READY to be added to a GitHub pull
request, however, someone with GitHub access needs to create a new branch, e.g.
'release4.1.1', so that I can create a pull request. 'release/4.1.1' could be
cleaner, and this is what is more common if you are using a GitFlow formatting.
GitHub does not seem to allow pull request to Tags, but DOES allow for
comparisons. Here is the completed feature:
https://github.com/apache/flex-flexunit/compare/4.1.0...Mixpo:feature/additionalCompilerOptions?expand=1
was (Author: haysclark):
This work has already been done and is READY to be added to a GitHub pull
request, however, someone with GitHub access needs to create a new branch, e.g.
'release4.1.1', so that I can create a pull request. GitHub does not seem to
allow pull request to Tags, but DOES allow for comparisons.
Here is the completed feature:
https://github.com/apache/flex-flexunit/compare/4.1.0...Mixpo:feature/additionalCompilerOptions?expand=1
> As a User, I would like FlexUnit 4.1.0 to support compiler options so I can
> easily compile more complicated Flash/Flex projects.
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLEX-35090
> URL: https://issues.apache.org/jira/browse/FLEX-35090
> Project: Apache Flex
> Issue Type: New Feature
> Components: FlexUnit
> Affects Versions: FlexUnit 4.1
> Reporter: Hays Clark
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The FlexUnit Ant task does not support compiler options, yet there are some
> custom forks online of FlexUnit which have added this support too 4.1.x.
> Instead of people having to hunt down those fork there should be a 4.1.x
> release which has this support. This feature should ideally added to 4.2.x
> if its does not 'break' any existing functionality.
> GradleFX both supports a 'additionalCompilerOptions' flag, but most FlexUnit
> tags are singular. Thus, 'additionalCompilerOption' seems like a good match.
> {code:title=Example.xml}
> <!-- Execute FlexUnit tests and publish reports -->
> <flexunit
> workingDir="${bin.loc}"
> toDir="${report.loc}"
> haltonfailure="false"
> verbose="true"
> localTrusted="true" >
> <additionalCompilerOption option="-define+=MY_CONST::foo,'BAR'" />
>
> </flexunit>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
