[
https://issues.apache.org/jira/browse/FLEX-34984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075803#comment-15075803
]
ASF GitHub Bot commented on FLEX-34984:
---------------------------------------
GitHub user adufilie opened a pull request:
https://github.com/apache/flex-falcon/pull/3
updated test cases with labeled for-each loops
See
https://issues.apache.org/jira/browse/FLEX-34984?focusedCommentId=15075728&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15075728
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adufilie/flex-falcon patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flex-falcon/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit a38e92b05c86fd79e929f85c53d3085941ad63e0
Author: Andy Dufilie <andy.dufi...@gmail.com>
Date: 2015-12-31T05:32:39Z
updated test cases with labeled for-each loops
----
> for-each loops cross-compile incorrectly
> ----------------------------------------
>
> Key: FLEX-34984
> URL: https://issues.apache.org/jira/browse/FLEX-34984
> Project: Apache Flex
> Issue Type: Bug
> Components: Falcon, FlexJS
> Affects Versions: Apache FlexJS 0.5.0
> Reporter: Andy Dufilie
> Assignee: Alex Harui
> Fix For: Apache FlexJS 0.6.0
>
>
> When you write a for-each loop, the iterable gets re-evaluated on every
> iteration.
> Example code:
> {code}
> for each (var item:Object in Test.getItems()) {
> Test.doSomething(item);
> }
> {code}
> Cross-compiled:
> {code}
> for (var foreachiter0 in Test.getItems())
> {
> var item = Test.getItems()[foreachiter0];
> {
> Test.doSomething(item);
> }}
> {code}
> It should not call Test.getItems() on every loop iteration. Instead, it
> should generate a new local variable prior to entering the loop to store the
> result:
> {code}
> var foreachiter0_target = Test.getItems();
> for (var foreachiter0 in foreachiter0_target)
> {
> var item = foreachiter0_target[foreachiter0];
> Test.doSomething(item);
> }
> {code}
> I can see problematic code in three places:
> * JSGeneratingReducer.java:
> https://github.com/apache/flex-falcon/blob/develop/compiler.js/src/org/apache/flex/compiler/internal/as/codegen/JSGeneratingReducer.java#L3426
> * ForEachEmitter.java:
> https://github.com/apache/flex-falcon/blob/develop/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/jx/ForEachEmitter.java
> * JSVF2JSEmitter.java:
> https://github.com/apache/flex-falcon/blob/develop/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/vf2js/JSVF2JSEmitter.java#L1708
> Another solution would be to use a for...of loop, Standard in ES6, though
> that won't work in Internet Explorer:
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
