Re: [PR] FINERACT-2528: fix Whimsy footer checks and document local verification [fineract-site]

[via GitHub]

meonkeys commented on code in PR #56:
URL: https://github.com/apache/fineract-site/pull/56#discussion_r2927256352


##########
site-src/layouts/partials/home-footer.html:
##########
@@ -8,7 +8,9 @@ <h3 class="white-text center-align">{{ $footer.reference_title 
}}</h3>
         <div class="ref-group">
           {{- range $footer.links }}
           <a class="ref-link waves-effect waves-light" href="{{ .href }}" 
target="_blank" rel="noopener">
-            <i class="material-icons" aria-hidden="true">{{ .icon }}</i>
+            <span class="icon-sr-only" aria-hidden="true">

Review Comment:
   why did you surround the `<i>` with a `<span>`?



##########
site-src/layouts/partials/home-footer.html:
##########
@@ -29,8 +31,16 @@ <h3 class="white-text center-align">{{ 
$footer.reference_title }}</h3>
 
       <div class="site-footer-legal center-align white-text">
         <p>
-          <a class="white-text" href="{{ $footer.apache_url }}" 
target="_blank" rel="noopener">Copyright &copy; {{ $footer.copyright_start 
}}&ndash;{{ now.Year }} The Apache Software Foundation</a>.
-          Licensed under the <a class="white-text" href="{{ 
$footer.license_url }}" target="_blank" rel="noopener">Apache License, Version 
2.0</a>.
+          <a class="white-text" href="{{ $footer.apache_url }}" 
target="_blank" rel="noopener">
+            Copyright &copy; {{ $footer.copyright_start }}&ndash;{{ now.Year 
}} The Apache Software Foundation
+          </a>.
+          Licensed under the
+          <a class="white-text" href="{{ $footer.license_url }}" 
target="_blank" rel="noopener">
+            Apache License, Version 2.0
+          </a>.
+          <a class="white-text" href="{{ $footer.privacy_url }}" 
target="_blank" rel="noopener">
+            Privacy Policy
+          </a>.

Review Comment:
   Why are you adding a link to the Privacy Policy? We already have one--this 
is not one of the failing whimsy checks



##########
site-src/layouts/partials/home-footer.html:
##########
@@ -29,8 +31,16 @@ <h3 class="white-text center-align">{{ 
$footer.reference_title }}</h3>
 
       <div class="site-footer-legal center-align white-text">
         <p>
-          <a class="white-text" href="{{ $footer.apache_url }}" 
target="_blank" rel="noopener">Copyright &copy; {{ $footer.copyright_start 
}}&ndash;{{ now.Year }} The Apache Software Foundation</a>.
-          Licensed under the <a class="white-text" href="{{ 
$footer.license_url }}" target="_blank" rel="noopener">Apache License, Version 
2.0</a>.
+          <a class="white-text" href="{{ $footer.apache_url }}" 
target="_blank" rel="noopener">
+            Copyright &copy; {{ $footer.copyright_start }}&ndash;{{ now.Year 
}} The Apache Software Foundation
+          </a>.
+          Licensed under the
+          <a class="white-text" href="{{ $footer.license_url }}" 
target="_blank" rel="noopener">
+            Apache License, Version 2.0
+          </a>.
+          <a class="white-text" href="{{ $footer.privacy_url }}" 
target="_blank" rel="noopener">

Review Comment:
   reformatting is great, but maybe do that in a separate PR. Here it's making 
it hard to see what actually changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org