edk12564 commented on PR #5597: URL: https://github.com/apache/fineract/pull/5597#issuecomment-4043487572
> sure. you can split ;) I see now after some reading that we can just have 2 PRs since the tests in our PR get run. Sorry about that. I made a lot of progress, and build was working locally. However, I am not done yet. I am just pushing so @Ambika-Sony can access these changes. Since they are required to pass builds/tests. I also found some endpoints in FinancialActivityAccountsApiResource that were named createGLAccount. However, it seems these endpoints actually map a GLAccount to a FinancialActivityAccount, and creating a GL Account is done in GLAccountResourceApi. I changed the operationId here to more closely match it's actual function. Thank you for being patient with me! Also, before merging, we must also make sure the order with Self-Service removal is correct. Currently I left self-service changes in. However, when the full merge to delete goes through, i can refactor to remove those changes. Just depends on which gets merged first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
