[
https://issues.apache.org/jira/browse/FINERACT-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015792#comment-18015792
]
Adam Monsen commented on FINERACT-2341:
---------------------------------------
Felix and I spoke.
* we agree releases should be versioned like "1.12.1", as we do today (no
change), and this number should be displayed consistently, e.g. in the
generated swagger HTML
* we found an incorrect version number 1.13.0-SNAPSHOT in the file
fineract-provider-1.12.1.jar in the apache-fineract-binary-1.12.1.tar.gz
release tarball ... in that file note how BOOT-INF/classes/static/fineract.json
has 1.13.0-SNAPSHOT under .info.version in the json data
* 1.13.0-SNAPSHOT appears in
[http://localhost:8080/fineract-provider/swagger-ui/index.html] , this may also
come from the fineract.json file above
* our preference for the web app is to display .git.commit.id.describe from
[http://localhost:8080/fineract-provider/actuator/info|http://localhost:8080/fineract-provider/actuator/info,]
e.g. "1.12.1" for a release or "1.12.1-105-g8f3ad9c" for, e.g. a non-release
build directly off the develop branch – this is more explicit, showing the
exact release/commit
* jar files should follow Maven version conventions, as such we agree the dev
release after 1.12.1 should be 1.13.0-SNAPSHOT
> Gradle versioning plugin configuration suggests wrong versions
> --------------------------------------------------------------
>
> Key: FINERACT-2341
> URL: https://issues.apache.org/jira/browse/FINERACT-2341
> Project: Apache Fineract
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.12.1
> Reporter: Felix Van Hove
> Priority: Trivial
>
> If I clone, check out a specific release of Fineract and then do `gradlew
> bootRun`, the running instance does not show the correct version. (This is
> not a new problem with 1.12.x, but had been the case with 1.11.0 too.)
> E.g. for 1.12.1, the Swagger UI displays 1.13.1-SNAPSHOT as the version. The
> same version appears here:
> {noformat}
> $ find . -name "fineract-*.jar" -path "*/build/*"
> ./fineract-accounting/build/libs/fineract-accounting-1.13.1-SNAPSHOT.jar
> ./fineract-avro-schemas/build/libs/fineract-avro-schemas-1.13.1-SNAPSHOT.jar
> ./fineract-branch/build/libs/fineract-branch-1.13.1-SNAPSHOT.jar
> ./fineract-charge/build/libs/fineract-charge-1.13.1-SNAPSHOT.jar
> ./fineract-command/build/libs/fineract-command-1.13.1-SNAPSHOT.jar
> ./fineract-core/build/libs/fineract-core-1.13.1-SNAPSHOT.jar
> ./fineract-document/build/libs/fineract-document-1.13.1-SNAPSHOT.jar
> ./fineract-investor/build/libs/fineract-investor-1.13.1-SNAPSHOT.jar
> ./fineract-loan/build/libs/fineract-loan-1.13.1-SNAPSHOT.jar
> ./fineract-progressive-loan/build/libs/fineract-progressive-loan-1.13.1-SNAPSHOT.jar
> ./fineract-rates/build/libs/fineract-rates-1.13.1-SNAPSHOT.jar
> ./fineract-report/build/libs/fineract-report-1.13.1-SNAPSHOT.jar
> ./fineract-savings/build/libs/fineract-savings-1.13.1-SNAPSHOT.jar
> ./fineract-tax/build/libs/fineract-tax-1.13.1-SNAPSHOT.jar
> ./fineract-validation/build/libs/fineract-validation-1.13.1-SNAPSHOT.jar
> {noformat}
> Correct would be 1.12.1.
> If I download a development version after the release 1.12.1, the same
> 1.13.1-SNAPSHOT version is generated. Correct would be 1.13.0-SNAPSHOT.
> The reason is a misconfiguration of the [Gradle versioning
> plugin|https://github.com/qoomon/gradle-git-versioning-plugin] via the file
> build.gradle.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
