[ 
https://issues.apache.org/jira/browse/CXF-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628026#comment-16628026
 ] 
ASF GitHub Bot commented on CXF-7843:
-------------------------------------

andymc12 commented on issue #446: CXF-7843: JAX-RS Headers Should Be Split by 
Default
URL: https://github.com/apache/cxf/pull/446#issuecomment-424529516
 
 
   @sberyozkin @jwcarman It does indeed look like this change will break the 
JAX-RS TCK... here are the tests that fail as a result of this change (plus 
#445):
   ```
   [javatest.batch] Finished Test:  
FAILED........com/sun/ts/tests/jaxrs/api/rs/core/link/JAXRSClient.java#fromResourceMethodLinkUsedInInvocationTest_from_standalone
   [javatest.batch] Finished Test:  
FAILED........com/sun/ts/tests/jaxrs/ee/rs/container/requestcontext/JAXRSClient.java#getHeadersIsMutableTest_from_standalone
   [javatest.batch] Finished Test:  
FAILED........com/sun/ts/tests/jaxrs/spec/provider/standardnotnull/JAXRSClient.java#clientBigDecimalProviderTest_from_standalone
   [javatest.batch] Finished Test:  
FAILED........com/sun/ts/tests/jaxrs/spec/provider/standardnotnull/JAXRSClient.java#clientBooleanProviderTest_from_standalone
   [javatest.batch] Finished Test:  
FAILED........com/sun/ts/tests/jaxrs/spec/provider/standardnotnull/JAXRSClient.java#clientCharProviderTest_from_standalone
   [javatest.batch] Finished Test:  
FAILED........com/sun/ts/tests/jaxrs/spec/provider/standardnotnull/JAXRSClient.java#clientIntegerProviderTest_from_standalone
   ```
   
   I will continue to look into these failures - my guess is that we are either 
missing something (i.e. handling of null values, etc.) or that the TCK is 
making some assumptions.  If it is the latter, we can challenge the TCK tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JAX-RS Headers Should Be Split by Default
> -----------------------------------------
>
>                 Key: CXF-7843
>                 URL: https://issues.apache.org/jira/browse/CXF-7843
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 3.2.6, 3.3.0
>            Reporter: James Carman
>            Assignee: Andy McCright
>            Priority: Major
>
> Upon reading the specification, I do not see any reason why the functionality 
> should be that the headers are concatenated together and it's a 
> vendor-specific setting to split them apart.  The return type is 
> MultivaluedMap.  If the headers were to be always concatenated, wouldn't they 
> just return a simple Map?  We should change the default behavior to split the 
> headers and only concatenate them if the "org.apache.cxf.http.header.split" 
> setting is specifically set to false.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to