[
https://issues.apache.org/jira/browse/CXF-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412167#comment-16412167
]
ASF GitHub Bot commented on CXF-7673:
-------------------------------------
johnament commented on a change in pull request #396: [CXF-7673] MP Rest Client
1.1 Impl
URL: https://github.com/apache/cxf/pull/396#discussion_r176874853
##########
File path:
rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java
##########
@@ -285,7 +285,8 @@ private static boolean isIgnorableParameter(Method m,
Parameter p) {
return true;
}
return p.getType() == ParameterType.REQUEST_BODY
- && m.getParameterTypes()[p.getIndex()] == AsyncResponse.class;
+ && (m.getParameterTypes()[p.getIndex()] == AsyncResponse.class
Review comment:
this would make it so that any client proxy can use `InvocationCallback`.
Is it worth adding sys tests that verify this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement MicroProfile Rest Client 1.1
> --------------------------------------
>
> Key: CXF-7673
> URL: https://issues.apache.org/jira/browse/CXF-7673
> Project: CXF
> Issue Type: New Feature
> Reporter: John D. Ament
> Assignee: Andy McCright
> Priority: Major
>
> Implement MP Rest Client 1.1
> * Async support
> * baseUri vs baseUrl
> * {{ProviderRegistrar}} support
>
> FYI [~andymc]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
