[ https://issues.apache.org/jira/browse/CXF-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403503#comment-16403503 ]
ASF GitHub Bot commented on CXF-7640: ------------------------------------- reta commented on a change in pull request #387: [CXF-7640] Create a form to set the use of Spring in the classHelper … URL: https://github.com/apache/cxf/pull/387#discussion_r175261686 ########## File path: core/src/main/java/org/apache/cxf/common/util/ClassHelper.java ########## @@ -69,19 +76,44 @@ protected Object getRealObjectInternal(Object o) { } public static Class<?> getRealClassFromClass(Class<?> cls) { - return HELPER.getRealClassFromClassInternal(cls); + Bus bus = getBus(null); + if (checkUseDefaultClassHelper(bus)) { Review comment: We could get rid of some duplication here: ``` private static getContextClassHelper(Bus bus) { // We could check if DEFAULT_HELPER and HELPER are referencing the same instance and than the bus property return (DEFAULT_HELPER == HELPER || checkUseDefaultClassHelper(bus)) ? DEFAULT_HELPER : HELPER; } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create a form to set the use of Spring in the classHelper on a per client way > ------------------------------------------------------------------------------ > > Key: CXF-7640 > URL: https://issues.apache.org/jira/browse/CXF-7640 > Project: CXF > Issue Type: Improvement > Components: Core > Reporter: Osvaldo Pina > Priority: Major > Attachments: cxf7640.txt > > > The solution for CXF-6191 allows for configuration of the use of Spring in > ClassHelper in a per vm way via System property. Would be nice to have a way > to configure it in a per instance way (or, at least, in a per classloader way) > > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)