[ 
https://issues.apache.org/jira/browse/CXF-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343129#comment-16343129
 ] 

William Montaz commented on CXF-7623:
-------------------------------------

Hi, looking at the discussion from the fix I saw this in the comments I wrote - 
>

"As you can notice, on version 3.0.5 
[https://github.com/apache/cxf/blob/cxf-3.0.5/rt/transports/http-hc/src/main/java/org/apache/cxf/transport/http/asyncclient/AsyncHTTPConduit.java]
 line 220, the RequestConfig sets a SocketTimeout equals to ReceiveTimeout. 
[...]In my merge request I propose to set it to ReceiveTimeout too, to stay 
close to the behavior proposed by CXF. But we could actually set a new property 
to distinguish both."

So I guess you can move to an extension to csPolicy and just make sure behavior 
is coherent on he whole stack. Sorry but I can't go deeper into the topic :(, 
it's been a long time and the issue fixed was not a trivial one 

> AsynchHTTPConduit setupConnection - timeout settings
> ----------------------------------------------------
>
>                 Key: CXF-7623
>                 URL: https://issues.apache.org/jira/browse/CXF-7623
>             Project: CXF
>          Issue Type: Bug
>          Components: Transports
>            Reporter: Antonin Fischer
>            Priority: Minor
>             Fix For: 3.2.2
>
>
> Class AsynchHTTPConduit method setupConnection(). Codeblock:
> {code:java}
> RequestConfig.Builder b = RequestConfig.custom()
>                 .setConnectTimeout((int) csPolicy.getConnectionTimeout())
>                 .setSocketTimeout((int) csPolicy.getReceiveTimeout())
>                 .setConnectionRequestTimeout((int) 
> csPolicy.getReceiveTimeout());
> {code}
> Line *setConnectionRequestTimeout((int) csPolicy.getReceiveTimeout())*
> Settings of request timeout with receive timeout is not backward compatible 
> solution. In addition the receive timeout is in many times to long. Better 
> way is set the *request timeout by connection timeout* instead of it. It is 
> still compromis solution.
> HTTPClientPolicy object still doesn't contain request timeout. Think about 
> extension of domain objects about request timeout which is already used in 
> pools etc.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to