[ 
https://issues.apache.org/jira/browse/CXF-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275774#comment-16275774
 ] 

ASF GitHub Bot commented on CXF-7571:
-------------------------------------

johnament commented on a change in pull request #351: [CXF-7571] Adding support 
for CDI injection of @Context objects.
URL: https://github.com/apache/cxf/pull/351#discussion_r154509322
 
 

 ##########
 File path: 
systests/cdi/base/src/main/java/org/apache/cxf/systests/cdi/base/BookStore.java
 ##########
 @@ -38,13 +39,11 @@
 @Path("/bookstore/")
 public class BookStore {
     @Inject private BookStoreService service;
-    @Inject private String version;
+    @Inject private BookStoreVersion bookStoreVersion;
 
-    @GET
     @Path("/version")
-    @Produces(MediaType.TEXT_PLAIN)
-    public String getVersion() {
-        return version;
+    public BookStoreVersion getVersion(@Context ResourceContext 
resourceContext) {
 
 Review comment:
   I need to remove this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


>  Revamp of the CXF injection implementation
> -------------------------------------------
>
>                 Key: CXF-7571
>                 URL: https://issues.apache.org/jira/browse/CXF-7571
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andriy Redko
>            Assignee: Andriy Redko
>
> As more deep integration with CDI revealed, there are complexities in 
> bringing together `@Context`- and `@Inject`-based injections. Encapsulating 
> CXF injection implementation and than delegating the hard work to appropriate 
> strategy (CDI, Spring, ...) would be the right solution to address the 
> problem at its roots.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to