[ 
https://issues.apache.org/jira/browse/CXF-6869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358972#comment-15358972
 ] 

Vedran Pavic commented on CXF-6869:
-----------------------------------

Hi Sergey,

{quote}
I'm OK with keeping cxf.path as is but if you happen to warm up a bit to a 
"cxf.servlet.path" idea, then let me know
{quote}

I'm personally in favor of {{cxf.path}} over {{cxf.servlet.path}}. IMO it's a 
good thing to be consistent with similar configuration properties in the Spring 
Boot itself.
Regarding the argument for modeling configuration properties this way, consider 
the {{web.xml}} itself - {{init-param}} and {{load-on-startup}} are attributes 
of the Servlet whereas the {{servlet-mapping}} is completely external to the 
Servlet.

Good to see you've added some support for more JAX-RS use cases.
With the latest change in mind I've got one suggestion for you to make the 
configuration more concise - you could merge {{jaxrs.classes-scan}} and 
{{jaxrs.component-scan}} properties into a single {{jaxrs.scan}} which is an 
enum consisting of {{NONE}} (default), {{CLASSES}} and {{COMPONENTS}}. IMO it 
makes sense since the options are mutually exclusive.

> Consider adding Spring Boot starter
> -----------------------------------
>
>                 Key: CXF-6869
>                 URL: https://issues.apache.org/jira/browse/CXF-6869
>             Project: CXF
>          Issue Type: New Feature
>          Components: Integration
>            Reporter: Vedran Pavic
>            Assignee: Sergey Beryozkin
>             Fix For: 3.1.7, 3.2.0
>
>
> I've recently authored a PR in Spring Boot to add support for 
> auto-configuration of {{CXFServlet}} and default CXF's configuration:
> https://github.com/spring-projects/spring-boot/pull/5659
> The PR was closed with "won't fix" resolution since Boot team are unwilling 
> to add CXF as a dependency to the project. Instead a 3rd party starter was 
> suggested.
> The concept of a 3rd party starter is generally encouraged for technologies 
> that don't have first-class support in projects from Spring portfolio. Such 
> 3rd party starters are listed here:
> https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/README.adoc
> If CXF team is interested, I'm willing to port my PR to CXF.
> Note that the original PR was focused around JAX-WS support, but can be 
> easily expanded to include JAX-RS support as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to